Issue 53873002: Frame::setView should not call confusingAndOftenMisusedAttached()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53873002: Frame::setView should not call confusingAndOftenMisusedAttached() (Closed)

Created:
7 years, 1 month ago by esprehn

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium, eseidel, ojan

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Frame::setView should not call confusingAndOftenMisusedAttached() This caller wants Document:isActive() instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161004

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/frame/Frame.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/53873002/1

7 years, 1 month ago (2013-10-31 01:06:13 UTC) #3

Message was sent while issue was closed.

Change committed as 161004