Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 538633003: Build fixes for GN mac build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Build fixes for GN mac build. TBR=jamesr Committed: https://crrev.com/fd3e9370842824fe3ee79344f1c748c07f826252 Cr-Commit-Position: refs/heads/master@{#293312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
brettw
6 years, 3 months ago (2014-09-03 21:17:35 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-03 21:17:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/538633003/1
6 years, 3 months ago (2014-09-03 23:24:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1890)
6 years, 3 months ago (2014-09-04 02:19:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/538633003/1
6 years, 3 months ago (2014-09-04 03:09:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1982)
6 years, 3 months ago (2014-09-04 03:54:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/538633003/1
6 years, 3 months ago (2014-09-04 16:36:11 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 14fb0967fb3e7ac9fa9d85d115afbc665b37f6cd
6 years, 3 months ago (2014-09-04 17:21:36 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:55 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd3e9370842824fe3ee79344f1c748c07f826252
Cr-Commit-Position: refs/heads/master@{#293312}

Powered by Google App Engine
This is Rietveld 408576698