mojo: Start generating structs for python bindings

mojo: Start generating structs for python bindings

R=pkl@chromium.org,cmasone@chromium.org

Committed: https://crrev.com/c53bf4ab6bdb3c05f61b8eb3851b15ab4591307a
Cr-Commit-Position: refs/heads/master@{#294161}

[qsr, 2014-09-04 15:18:04]

CC: +tburkard

[pkl (ping after 24h if needed), 2014-09-04 18:12:12]

https://chromiumcodereview.appspot.com/538613005/diff/60001/mojo/public/tools...
File mojo/public/tools/bindings/generators/python_templates/module.py.tmpl
(right):

https://chromiumcodereview.appspot.com/538613005/diff/60001/mojo/public/tools...
mojo/public/tools/bindings/generators/python_templates/module.py.tmpl:34:
'{{constant|name}}': {{constant.value|expression_to_text}}
missing , at the end?

[qsr, 2014-09-05 11:55:49]

https://chromiumcodereview.appspot.com/538613005/diff/60001/mojo/public/tools...
File mojo/public/tools/bindings/generators/python_templates/module.py.tmpl
(right):

https://chromiumcodereview.appspot.com/538613005/diff/60001/mojo/public/tools...
mojo/public/tools/bindings/generators/python_templates/module.py.tmpl:34:
'{{constant|name}}': {{constant.value|expression_to_text}}
On 2014/09/04 18:12:12, pklpkl wrote:
> missing , at the end?

Done.

[pkl (ping after 24h if needed), 2014-09-05 14:14:45]

lgtm

[qsr, 2014-09-09 08:20:24]

qsr@chromium.org changed reviewers:
+ sdefresne@chromium.org

[qsr, 2014-09-09 08:20:25]

+sdefresne

[sdefresne, 2014-09-09 08:51:57]

lgtm

https://codereview.chromium.org/538613005/diff/80001/mojo/public/python/mojo/...
File mojo/public/python/mojo/bindings/reflection.py (right):

https://codereview.chromium.org/538613005/diff/80001/mojo/public/python/mojo/...
mojo/public/python/mojo/bindings/reflection.py:72: '__slots__': [],
nit: maybe you want to keep the __module__ here from dictionary.

https://codereview.chromium.org/538613005/diff/80001/mojo/python/tests/bindin...
File mojo/python/tests/bindings_constants_unittest.py (right):

https://codereview.chromium.org/538613005/diff/80001/mojo/python/tests/bindin...
mojo/python/tests/bindings_constants_unittest.py:39:
sample_service_mojom.Foo.BAR = 1
Q: just to be sure, but this is testing that user cannot add new values to the
struct, right?

[qsr, 2014-09-09 08:55:11]

https://codereview.chromium.org/538613005/diff/80001/mojo/public/python/mojo/...
File mojo/public/python/mojo/bindings/reflection.py (right):

https://codereview.chromium.org/538613005/diff/80001/mojo/public/python/mojo/...
mojo/public/python/mojo/bindings/reflection.py:72: '__slots__': [],
On 2014/09/09 08:51:57, sdefresne wrote:
> nit: maybe you want to keep the __module__ here from dictionary.

 I fixed all of this in the following CL
(https://chromiumcodereview.appspot.com/551053002/), I can backport it here
directly if you prefer.

https://codereview.chromium.org/538613005/diff/80001/mojo/python/tests/bindin...
File mojo/python/tests/bindings_constants_unittest.py (right):

https://codereview.chromium.org/538613005/diff/80001/mojo/python/tests/bindin...
mojo/python/tests/bindings_constants_unittest.py:39:
sample_service_mojom.Foo.BAR = 1
On 2014/09/09 08:51:57, sdefresne wrote:
> Q: just to be sure, but this is testing that user cannot add new values to the
> struct, right?

 Exactly.

[sdefresne, 2014-09-09 09:30:36]

Still lgtm.

https://codereview.chromium.org/538613005/diff/80001/mojo/public/python/mojo/...
File mojo/public/python/mojo/bindings/reflection.py (right):

https://codereview.chromium.org/538613005/diff/80001/mojo/public/python/mojo/...
mojo/public/python/mojo/bindings/reflection.py:72: '__slots__': [],
On 2014/09/09 08:55:10, qsr wrote:
> On 2014/09/09 08:51:57, sdefresne wrote:
> > nit: maybe you want to keep the __module__ here from dictionary.
> 
>  I fixed all of this in the following CL
> (https://chromiumcodereview.appspot.com/551053002/), I can backport it here
> directly if you prefer.

Ok, no need to backport.

[qsr, 2014-09-10 08:25:20]

The CQ bit was checked by qsr@chromium.org

[qsr, 2014-09-10 08:25:21]

The CQ bit was unchecked by qsr@chromium.org

[qsr, 2014-09-10 08:25:24]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-10 08:26:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/538613005/80001

[commit-bot: I haz the power, 2014-09-10 08:29:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 08:29:38]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qsr, 2014-09-10 11:06:18]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-10 11:07:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/538613005/80001

[commit-bot: I haz the power, 2014-09-10 12:53:59]

Committed patchset #5 (id:80001) as d2806c41298118db32300750069651702bc60c57

[commit-bot: I haz the power, 2014-09-10 12:58:21]

Patchset 5 (id:??) landed as
https://crrev.com/c53bf4ab6bdb3c05f61b8eb3851b15ab4591307a
Cr-Commit-Position: refs/heads/master@{#294161}