LayoutTests/fast/repaint/align-content-change.html - Issue 538613003: Don't always full invalidate on change of align-content, align-items and align-self.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/repaint/align-content-change.html

Issue 538613003: Don't always full invalidate on change of align-content, align-items and align-self. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="resources/text-based-repaint.js"></script>

	3 <script>

	4 function repaintTest() {

	5 document.getElementById('container').style.alignContent = 'stretch';

	6 }

	7 onload = runRepaintTest;

	8 </script>

	9 <style>

	10 body {

	11 margin: 0;

	12 }

	13 #container {

	14 display: flex;

	15 align-content: space-around;

	16 flex-flow: row wrap;

	17 width: 200px;

	18 height: 300px;

	19 background-color: red;

	20 }

	21 .item {

	22 background-color: green;

	23 border: solid thin blue;

	24 width: 200px;

	25 }

	26 </style>

	27 <p style="height: 20px">Tests repaint on align-content style change. Passes if t here is no red.</p>
	dsinclair 2014/09/03 20:48:12 Can this be a ref test instead of a -expected.txt? Can this be a ref test instead of a -expected.txt? (and the others which pass if there is no red) dsinclair 2014/09/03 20:48:12 s/repaint/invalidation s/repaint/invalidation Xianzhu 2014/09/03 21:29:20 Done. Show quoted text On 2014/09/03 20:48:12, dsinclair wrote: > s/repaint/invalidation Done. Xianzhu 2014/09/03 21:29:20 I think ref test can't replace a repaint(invalidat Show quoted text On 2014/09/03 20:48:12, dsinclair wrote: > Can this be a ref test instead of a -expected.txt? (and the others which pass if > there is no red) I think ref test can't replace a repaint(invalidation)-test for testing correct invalidation: - a ref test might hide under invalidation because we may paint more than invalidated area; - we can't test over-invalidation with a ref test. dsinclair 2014/09/04 14:10:45 Ah, k, I thought you were just testing correctness Show quoted text On 2014/09/03 21:29:20, Xianzhu wrote: > On 2014/09/03 20:48:12, dsinclair wrote: > > Can this be a ref test instead of a -expected.txt? (and the others which pass > if > > there is no red) > > I think ref test can't replace a repaint(invalidation)-test for testing correct > invalidation: > - a ref test might hide under invalidation because we may paint more than > invalidated area; > - we can't test over-invalidation with a ref test. Ah, k, I thought you were just testing correctness, didn't realize you were also looking for minimal invalidation rects.
	28 <div id="container">

	29 <div class="item">

	30 <div style="height: 50px"></div>

	31 </div>

	32 <div class="item">

	33 <div style="height: 50px"></div>

	34 </div>

	35 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/repaint/align-content-change-expected.txt » ('j') | no next file with comments »