Refactored frontend for the rebaseline server.

Refactored frontend for the rebaseline server.
This is going to serve as the starting point for the new front-end once the backend is rewritten.

BUG=skia:
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/03e844a0bc5f7b5dff14e3a06e8fc4ab6bfb16ea

[stephana, 2014-09-03 19:20:52]

stephana@google.com changed reviewers:
+ jcgregorio@google.com

[stephana, 2014-09-04 13:29:54]

This is going to be the starting point for the new UI once the backend is ready.

[jcgregorio, 2014-09-04 18:37:32]

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/new/css/app.css (right):

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/css/app.css:3: .digit-4 {
.digit4 to keep it consistent with all the other names?

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/css/app.css:4: width: 4em !important;
Why the need for !important?

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/css/app.css:33: .results-header-actions {
.resultsHeaderActions

Same for .sort-desc and the other - delimited CSS names below.

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/new/js/app.js (right):

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/js/app.js:38: // column types
Keep app comments full sentences.

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/js/app.js:43: // different modes of rendering
So if this is only going to be used for the new stuff, we should only care about
DM, right?

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/js/app.js:326: * Generate a CSS class based on
whether the identified column is currently
Is the CSS class also used to control the display?

[stephana, 2014-09-05 14:37:16]

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/new/css/app.css (right):

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/css/app.css:3: .digit-4 {
Agreed. This one is actually not necessary used in markup, I'll remove it, but
make sure that class names are consistent.

On 2014/09/04 18:37:32, jcgregorio wrote:
> .digit4 to keep it consistent with all the other names?

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/css/app.css:4: width: 4em !important;
This one is being removed, but in general I am usually using "!important" so I
don't have to spell out a long selector. 
The selector I am overriding in bootstrap is more specific, thus has
precedence unless I use !important. 

On 2014/09/04 18:37:32, jcgregorio wrote:
> Why the need for !important?

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/css/app.css:33: .results-header-actions {
On 2014/09/04 18:37:32, jcgregorio wrote:
> .resultsHeaderActions
> 
> Same for .sort-desc and the other - delimited CSS names below.

Done.

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/new/js/app.js (right):

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/js/app.js:38: // column types
On 2014/09/04 18:37:32, jcgregorio wrote:
> Keep app comments full sentences.

Done.

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/js/app.js:43: // different modes of rendering
Yes. This was added when it wasn't as clear to me that we are targeting 'dm'. I
removee as much as I could find of the gm specific code, but I will have to do
another sweep once the new backend is ready.

On 2014/09/04 18:37:32, jcgregorio wrote:
> So if this is only going to be used for the new stuff, we should only care
about
> DM, right?

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/js/app.js:326: * Generate a CSS class based on
whether the identified column is currently
Changed this comment to make it clearer how this will be used. Namely to draw
the little up/down arrow next to a column name if this column is the sort key.

On 2014/09/04 18:37:32, jcgregorio wrote:
> Is the CSS class also used to control the display?

[jcgregorio, 2014-09-05 18:21:45]

LGTM

The class !important discussion is veering into academic territory which doesn't
really affect this CL.

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/new/css/app.css (right):

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/css/app.css:4: width: 4em !important;
Won't that be a problem later if you want to change the width of an element that
already has .digit4?

On 2014/09/05 14:37:16, stephana wrote:
> This one is being removed, but in general I am usually using "!important" so I
> don't have to spell out a long selector. 
> The selector I am overriding in bootstrap is more specific, thus has
> precedence unless I use !important. 
> 
> On 2014/09/04 18:37:32, jcgregorio wrote:
> > Why the need for !important?
>

[stephana, 2014-09-05 20:50:59]

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/new/css/app.css (right):

https://codereview.chromium.org/538613002/diff/40001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/new/css/app.css:4: width: 4em !important;
The digit4 class was residue from an earlier version and should have been
removed when I removed the HTML element that used it. 

On 2014/09/05 18:21:45, jcgregorio wrote:
> Won't that be a problem later if you want to change the width of an element
that
> already has .digit4?
> 
> On 2014/09/05 14:37:16, stephana wrote:
> > This one is being removed, but in general I am usually using "!important" so
I
> > don't have to spell out a long selector. 
> > The selector I am overriding in bootstrap is more specific, thus has
> > precedence unless I use !important. 
> > 
> > On 2014/09/04 18:37:32, jcgregorio wrote:
> > > Why the need for !important?
> > 
>

[stephana, 2014-09-05 20:51:02]

The CQ bit was checked by stephana@google.com

[commit-bot: I haz the power, 2014-09-05 20:51:19]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/stephana@google.com/538613002/60001

[commit-bot: I haz the power, 2014-09-05 20:51:28]

Committed patchset #4 (id:60001) as 03e844a0bc5f7b5dff14e3a06e8fc4ab6bfb16ea