Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 538603002: Re-recorded tough_energy_cases. (Closed)

Created:
6 years, 3 months ago by sullivan
Modified:
6 years, 2 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org, tonyg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-recorded tough_energy_cases. Fixed bug in recording where it would not download credentials. BUG= Committed: https://crrev.com/776c7121698e0892ab8eefae478ab15dac2572f8 Cr-Commit-Position: refs/heads/master@{#293233}

Patch Set 1 #

Patch Set 2 : Updated error message for missing credentials #

Total comments: 2

Patch Set 3 : Split _UpdateCredentials into its own function #

Patch Set 4 : Re-recorded tough_energy_cases #

Patch Set 5 : Add a tab_switching.flash_energy_cases benchmark. #

Patch Set 6 : Create a flash-heavy page set for tab_switching #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M tools/perf/benchmarks/tab_switching.py View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/flash_energy_cases.json View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/flash_energy_cases_000.wpr.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/flash_energy_cases.py View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sullivan
6 years, 3 months ago (2014-09-03 18:38:16 UTC) #2
dtu
https://codereview.chromium.org/538603002/diff/20001/tools/telemetry/telemetry/page/page_runner.py File tools/telemetry/telemetry/page/page_runner.py (right): https://codereview.chromium.org/538603002/diff/20001/tools/telemetry/telemetry/page/page_runner.py#newcode375 tools/telemetry/telemetry/page/page_runner.py:375: _UpdatePageSetArchivesIfChanged(page_set) I think we should break _UpdatePageSetArchivesIfChanged into _UpdateCredentials ...
6 years, 3 months ago (2014-09-03 18:44:52 UTC) #3
sullivan
https://codereview.chromium.org/538603002/diff/20001/tools/telemetry/telemetry/page/page_runner.py File tools/telemetry/telemetry/page/page_runner.py (right): https://codereview.chromium.org/538603002/diff/20001/tools/telemetry/telemetry/page/page_runner.py#newcode375 tools/telemetry/telemetry/page/page_runner.py:375: _UpdatePageSetArchivesIfChanged(page_set) On 2014/09/03 18:44:52, dtu wrote: > I think ...
6 years, 3 months ago (2014-09-03 18:52:43 UTC) #4
dtu
lgtm
6 years, 3 months ago (2014-09-03 20:36:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/538603002/40001
6 years, 3 months ago (2014-09-03 20:38:10 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 26a2fcaad78065d9f57fda0a160f28db58aebe2d
6 years, 3 months ago (2014-09-04 00:20:42 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:57 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/776c7121698e0892ab8eefae478ab15dac2572f8
Cr-Commit-Position: refs/heads/master@{#293233}

Powered by Google App Engine
This is Rietveld 408576698