Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: net/socket/ssl_host_info.h

Issue 5386001: Cache certificate verification results in memory. (Closed) Base URL: svn://
Patch Set: Add unit tests. Ready for review. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_host_info.h
--- net/socket/ssl_host_info.h (revision 68922)
+++ net/socket/ssl_host_info.h (working copy)
@@ -11,13 +11,13 @@
#include "base/ref_counted.h"
#include "base/scoped_ptr.h"
#include "base/time.h"
+#include "net/base/cert_verifier.h"
#include "net/base/cert_verify_result.h"
#include "net/base/completion_callback.h"
#include "net/socket/ssl_client_socket.h"
namespace net {
-class CertVerifier;
class X509Certificate;
struct SSLConfig;
@@ -27,7 +27,9 @@
// certificates.
class SSLHostInfo {
- SSLHostInfo(const std::string& hostname, const SSLConfig& ssl_config);
+ SSLHostInfo(const std::string& hostname,
+ const SSLConfig& ssl_config,
+ CertVerifier *certVerifier);
virtual ~SSLHostInfo();
// Start will commence the lookup. This must be called before any other
@@ -117,7 +119,7 @@
bool verify_ev_cert_;
base::TimeTicks verification_start_time_;
CertVerifyResult cert_verify_result_;
- scoped_ptr<CertVerifier> verifier_;
+ SingleRequestCertVerifier verifier_;
scoped_refptr<X509Certificate> cert_;
scoped_refptr<CancelableCompletionCallback<SSLHostInfo> > callback_;

Powered by Google App Engine
This is Rietveld 408576698