Cache certificate verification results in memory.

net/socket/client_socket_pool_manager.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // ClientSocketPoolManager manages access to all ClientSocketPools.  It's a
 // simple container for all of them.  Most importantly, it handles the lifetime
 // and destruction order properly.
 
-#ifndef NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_
-#define NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_
+#ifndef NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_
+#define NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_

[willchan no longer on Chromium, 2010/12/13 09:30:53]

Thanks for all the cleanup in this file!  I feel a bit stupid for those silly
mistakes.

 #pragma once
 
 #include <map>
 #include "base/basictypes.h"
 #include "base/non_thread_safe.h"
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "base/template_util.h"
 #include "base/stl_util-inl.h"
 #include "net/socket/client_socket_pool_histograms.h"
 
 class Value;
 
 namespace net {
 
+class CertVerifier;
 class ClientSocketFactory;
 class ClientSocketPoolHistograms;
 class DnsCertProvenanceChecker;
 class DnsRRResolver;
 class HostPortPair;
 class HttpProxyClientSocketPool;
 class HostResolver;
 class NetLog;
 class ProxyService;
 class SOCKSClientSocketPool;
@@ skipping 11 matching lines @@
   OwnedPoolMap() {
     COMPILE_ASSERT(base::is_pointer<Value>::value,
                    value_must_be_a_pointer);
   }
 
   ~OwnedPoolMap() {
     STLDeleteValues(this);
   }
 };
 
-}  // internal
+}  // namespace internal
 
 class ClientSocketPoolManager : public NonThreadSafe {
  public:
   ClientSocketPoolManager(NetLog* net_log,
                           ClientSocketFactory* socket_factory,
                           HostResolver* host_resolver,
+                          CertVerifier* cert_verifier,
                           DnsRRResolver* dnsrr_resolver,
                           DnsCertProvenanceChecker* dns_cert_checker,
                           SSLHostInfoFactory* ssl_host_info_factory,
                           ProxyService* proxy_service,
                           SSLConfigService* ssl_config_service);
   ~ClientSocketPoolManager();
 
   void FlushSocketPools();
 
   TCPClientSocketPool* tcp_socket_pool() { return tcp_socket_pool_.get(); }
@@ skipping 25 matching lines @@
   typedef internal::OwnedPoolMap<HostPortPair, SOCKSClientSocketPool*>
       SOCKSSocketPoolMap;
   typedef internal::OwnedPoolMap<HostPortPair, HttpProxyClientSocketPool*>
       HTTPProxySocketPoolMap;
   typedef internal::OwnedPoolMap<HostPortPair, SSLClientSocketPool*>
       SSLSocketPoolMap;
 
   NetLog* const net_log_;
   ClientSocketFactory* const socket_factory_;
   HostResolver* const host_resolver_;
+  CertVerifier* const cert_verifier_;
   DnsRRResolver* const dnsrr_resolver_;
   DnsCertProvenanceChecker* const dns_cert_checker_;
   SSLHostInfoFactory* const ssl_host_info_factory_;
   const scoped_refptr<ProxyService> proxy_service_;
   const scoped_refptr<SSLConfigService> ssl_config_service_;
 
   // Note: this ordering is important.
 
   ClientSocketPoolHistograms tcp_pool_histograms_;
   scoped_ptr<TCPClientSocketPool> tcp_socket_pool_;
@@ skipping 20 matching lines @@
   HTTPProxySocketPoolMap http_proxy_socket_pools_;
 
   ClientSocketPoolHistograms ssl_socket_pool_for_proxies_histograms_;
   SSLSocketPoolMap ssl_socket_pools_for_proxies_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientSocketPoolManager);
 };
 
 }  // namespace net
 
-#endif // NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_
+#endif  // NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_