Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: ipc/ipc_test_base.h

Issue 538593002: Fix a DCHECK violation in ipc_perftests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ipc_perf
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_perftests.cc ('k') | ipc/ipc_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_test_base.h
diff --git a/ipc/ipc_test_base.h b/ipc/ipc_test_base.h
index acad47764368c9a0ac4988076ac2ca647afdad30..c346f51398c548d1dda9f47489117adc95183ed0 100644
--- a/ipc/ipc_test_base.h
+++ b/ipc/ipc_test_base.h
@@ -33,11 +33,17 @@ class IPCTestBase : public base::MultiProcessTest {
IPCTestBase();
virtual ~IPCTestBase();
- virtual void SetUp() OVERRIDE;
virtual void TearDown() OVERRIDE;
- // Initializes the test to use the given client.
+ // Initializes the test to use the given client and creates an IO message loop
+ // on the current thread.
void Init(const std::string& test_client_name);
+ // Some tests create separate thread for IO message loop and run non-IO
+ // message loop on the main thread. As IPCTestBase creates IO message loop by
+ // default, such tests need to provide a custom message loop for the main
+ // thread.
+ void InitWithCustomMessageLoop(const std::string& test_client_name,
+ scoped_ptr<base::MessageLoop> message_loop);
// Creates a channel with the given listener and connects to the channel
// (returning true if successful), respectively. Use these to use a channel
@@ -88,16 +94,6 @@ class IPCTestBase : public base::MultiProcessTest {
const base::ProcessHandle& client_process() const { return client_process_; }
scoped_refptr<base::TaskRunner> task_runner();
- // Some tests creates separate thread for IO message loop and Run
- // non-IO message loop on the main thread. As IPCTestBase creates IO
- // message loop by default, such tests might want to replace it with
- // non-IO one using set_message_loop().
- //
- // The replacement should be done at the beginning of the test.
- // You should be careful not to replace "live" message loop that has
- // started running.
- void set_message_loop(scoped_ptr<base::MessageLoop> loop);
-
private:
std::string test_client_name_;
scoped_ptr<base::MessageLoop> message_loop_;
« no previous file with comments | « ipc/ipc_perftests.cc ('k') | ipc/ipc_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698