Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 538593002: Fix a DCHECK violation in ipc_perftests (Closed)

Created:
6 years, 3 months ago by yzshen1
Modified:
6 years, 3 months ago
Reviewers:
Hajime Morrita, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_perf
Project:
chromium
Visibility:
Public.

Description

Fix a DCHECK violation in ipc_perftests We only allow one MessageLoop instance alive at any given time on a thread. If we use IPCTestBase::set_message_loop(), we need to do it in two steps: first set the message loop to NULL, and then set it to a newly-created message loop. Therefore, I changed the interface of IPCTestBase to make it a little more friendly. BUG=None TEST=ipc_perftests should not crash in debug build. Committed: https://crrev.com/22796d8d5fd362111b7aa431d229aa2ffc91aedd Cr-Commit-Position: refs/heads/master@{#293439}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M ipc/ipc_perftests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_test_base.h View 1 2 chunks +8 lines, -12 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 2 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yzshen1
Hi, Hajime and John. Would you please take a look? Thanks! Hajime: everything. John: high-level ...
6 years, 3 months ago (2014-09-03 18:02:02 UTC) #2
Hajime Morrita
lgtm. thanks for the fix. Still needs lgtm from jam@
6 years, 3 months ago (2014-09-03 19:06:04 UTC) #3
jam
lgtm
6 years, 3 months ago (2014-09-04 22:24:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/538593002/20001
6 years, 3 months ago (2014-09-04 22:26:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e61fbc2d16c4f5476b92e242332436a161f57ae6
6 years, 3 months ago (2014-09-05 04:43:39 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22796d8d5fd362111b7aa431d229aa2ffc91aedd
Cr-Commit-Position: refs/heads/master@{#293439}

Powered by Google App Engine
This is Rietveld 408576698