Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 538553002: Fix r23638 "Convert Linkage to use MachineSignature." for crankshaft only architectures. (Closed)

Created:
6 years, 3 months ago by balazs.kilvady
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix r23638 "Convert Linkage to use MachineSignature." for crankshaft only architectures. BUG= R=paul.lind@imgtec.com, titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/compiler/linkage.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
6 years, 3 months ago (2014-09-03 16:11:11 UTC) #2
paul.l...
LGTM, but we need a v8 team reviewer for this one.
6 years, 3 months ago (2014-09-03 16:22:26 UTC) #4
titzer
lgtm lgtm
6 years, 3 months ago (2014-09-03 16:25:41 UTC) #5
titzer
lgtm
6 years, 3 months ago (2014-09-03 16:25:42 UTC) #6
balazs.kilvady
6 years, 3 months ago (2014-09-03 16:29:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as 23665 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698