Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 538543004: Fix <label> misuses in content settings (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix <label> misuses in content settings BUG=409938 Committed: https://crrev.com/2f769f3487d3b8b6a0c2fefa816bf6aa44fde676 Cr-Commit-Position: refs/heads/master@{#293221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -279 lines) Patch
M chrome/browser/resources/options/content_settings.html View 9 chunks +177 lines, -279 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Evan Stade
more of the same
6 years, 3 months ago (2014-09-03 19:15:20 UTC) #2
arv (Not doing code reviews)
LGTM I'm kind of surprised that we never use the IDs from code though.
6 years, 3 months ago (2014-09-03 19:50:38 UTC) #3
Evan Stade
On 2014/09/03 19:50:38, arv wrote: > LGTM > > I'm kind of surprised that we ...
6 years, 3 months ago (2014-09-03 19:54:13 UTC) #4
Evan Stade
6 years, 3 months ago (2014-09-03 19:54:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/538543004/1
6 years, 3 months ago (2014-09-03 19:55:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4659b81e62f77246e8a9965b24bdeb5f8a7f851e
6 years, 3 months ago (2014-09-03 23:41:37 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f769f3487d3b8b6a0c2fefa816bf6aa44fde676
Cr-Commit-Position: refs/heads/master@{#293221}

Powered by Google App Engine
This is Rietveld 408576698