Fix copying of SAML IdP cookies on subsequent logins

Fix copying of SAML IdP cookies on subsequent logins

The code that copies cookies set by a SAML IdP on subsequent logins is
wrong as it uses a method which modifies the cookie being copied by
prepending a dot to the domain name. This CL fixes the problem by
switching to the method that is used during initial login. The method
is also renamed to make it clearer that it may be used on subsequent
logins too.

BUG=410416
TEST=unit_tests updated to detect this problem

TBR=dbeam (wallet_signin_helper_unittest.cc)

Committed: https://crrev.com/a13acdf708616561b245fdb5184cf13e6f8b8a66
Cr-Commit-Position: refs/heads/master@{#293524}

[bartfab (slow), 2014-09-03 18:58:10]

bartfab@chromium.org changed reviewers:
+ antrim@chromium.org, erikwright@chromium.org

[bartfab (slow), 2014-09-03 18:58:11]

Hi Denis,

Could you please review chrome/browser/chromeos/login/*?

Hi Erik,

Could you please review net/cookies/cookie_monster.*?

[erikwright (departed), 2014-09-04 15:09:04]

net/cookies LGTM

[Denis Kuznetsov (DE-MUC), 2014-09-04 15:54:44]

https://chromiumcodereview.appspot.com/538543003/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/profile_auth_data_unittest.cc (right):

https://chromiumcodereview.appspot.com/538543003/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/profile_auth_data_unittest.cc:279: void
ProfileAuthDataTest::QuitLoop(const net::CookieList& ignored) {
What is the reason for changing signature of the method?
I feel like I'm missing something.

[bartfab (slow), 2014-09-04 17:02:44]

https://chromiumcodereview.appspot.com/538543003/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/profile_auth_data_unittest.cc (right):

https://chromiumcodereview.appspot.com/538543003/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/profile_auth_data_unittest.cc:279: void
ProfileAuthDataTest::QuitLoop(const net::CookieList& ignored) {
On 2014/09/04 15:54:44, Denis Kuznetsov wrote:
> What is the reason for changing signature of the method?
> I feel like I'm missing something.

We used to call cookies->SetCookieWithDetailsAsync() which expects a callback
that takes a |bool|. We wanted this callback to quit the current message loop,
so we fed it QuitLoop(bool ignored).

We no longer call this method, so QuitLoop(bool ignored) is no longer needed.
But we call cookies->GetAllCookiesAsync() now, which expects a callback that
takes a |const net::CookieList&|. We want *this* callback to quit the current
message loop, so we feed it a new helper method that ignores the |const
net::CookieList&| argument and quits the current loop.

So what you are seeing is the retirement of one helper method we no longer need
and the introduction of another helper. Both have the same name, because they do
the same thing.

[Denis Kuznetsov (DE-MUC), 2014-09-05 11:40:38]

Ah, I see.
lgtm.

[bartfab (slow), 2014-09-05 11:51:45]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-09-05 11:52:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/538543003/1

[commit-bot: I haz the power, 2014-09-05 12:11:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 12:11:17]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[bartfab (slow), 2014-09-05 12:38:36]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-09-05 12:38:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/538543003/20001

[commit-bot: I haz the power, 2014-09-05 15:08:29]

Committed patchset #2 (id:20001) as 585871ef3e26e5813a96b0372d83284acdddbdb5

[commit-bot: I haz the power, 2014-09-10 03:39:42]

Patchset 2 (id:??) landed as
https://crrev.com/a13acdf708616561b245fdb5184cf13e6f8b8a66
Cr-Commit-Position: refs/heads/master@{#293524}