Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 538473002: DevTools: NetworkPanel: headers missing for cors-cancelled requests. (Closed)

Created:
6 years, 3 months ago by eustas
Modified:
6 years, 3 months ago
Reviewers:
vsevik
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: NetworkPanel: headers missing for cors-cancelled requests. InspectorInstrumentation::didReceiveResourceResponse should be called whenever it comes clear that request won't be finished normally. BUG=409739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181923

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M Source/core/loader/DocumentThreadableLoader.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 1 4 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
eustas
6 years, 3 months ago (2014-09-03 10:37:08 UTC) #2
eustas
PTAL
6 years, 3 months ago (2014-09-08 12:02:46 UTC) #3
vsevik
lgtm
6 years, 3 months ago (2014-09-10 22:07:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/538473002/20001
6 years, 3 months ago (2014-09-10 22:07:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26526)
6 years, 3 months ago (2014-09-11 02:04:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/538473002/20001
6 years, 3 months ago (2014-09-12 18:39:41 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:13:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181923

Powered by Google App Engine
This is Rietveld 408576698