Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 538463003: Disable SSE4 S32A_Opaque blit. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Disable SSE4 S32A_Opaque blit. This code sometimes generates a build warning that bothers Chrome. BUG=399842, skia:2906 Committed: https://skia.googlesource.com/skia/+/eddb113ec65226a1563fe9e623e7408443499028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/opts/SkBlitRow_opts_SSE4.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE4_asm.S View 2 chunks +4 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE4_x64_asm.S View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
6 years, 3 months ago (2014-09-03 13:51:43 UTC) #2
reed1
lgtm
6 years, 3 months ago (2014-09-03 13:53:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/538463003/1
6 years, 3 months ago (2014-09-03 13:55:15 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 14:02:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as eddb113ec65226a1563fe9e623e7408443499028

Powered by Google App Engine
This is Rietveld 408576698