Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2126)

Unified Diff: build/secondary/third_party/icu/BUILD.gn

Issue 538333002: gn/linux: warnings as errors, turn on Wextra (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/secondary/third_party/libsrtp/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/icu/BUILD.gn
diff --git a/build/secondary/third_party/icu/BUILD.gn b/build/secondary/third_party/icu/BUILD.gn
index 4f7f0888634638e6ed6a1b0c710514ca7ee03388..1a219491e8a6ba00e82a8c9e5ebdf98794bd3c56 100644
--- a/build/secondary/third_party/icu/BUILD.gn
+++ b/build/secondary/third_party/icu/BUILD.gn
@@ -258,13 +258,20 @@ component("icui18n") {
configs += [ ":icu_code" ]
direct_dependent_configs = [ ":icu_config" ]
+ cflags = []
+ if (is_android || is_linux) {
+ cflags += [
+ # ICU uses its own deprecated functions.
+ "-Wno-deprecated-declarations",
+ ]
+ }
if (is_clang) {
# uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
# the header should use U_NAMESPACE_BEGIN instead.
# http://bugs.icu-project.org/trac/ticket/9054
configs -= [ "//build/config/clang:extra_warnings" ]
- cflags = [
+ cflags += [
"-Wno-header-hygiene",
# Looks like a real issue, see http://crbug.com/114660
"-Wno-return-type-c-linkage",
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/secondary/third_party/libsrtp/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698