Source/web/WebRemoteFrameImpl.cpp - Issue 538323003: Have window.closed return true when frame is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 538323003: Have window.closed return true when frame is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Un-inline and improve formatting of Frame::setHasBeenClosed() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebRemoteFrameImpl.cpp

diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp

index fa8cf649652b77b0bd3b94c031167ffa12049fd9..f0a16a1e03eb91e991d917f266f6695082ddb0cc 100644

--- a/Source/web/WebRemoteFrameImpl.cpp

+++ b/Source/web/WebRemoteFrameImpl.cpp

@@ -130,6 +130,9 @@ WebRemoteFrame* WebRemoteFrameImpl::toWebRemoteFrame()

void WebRemoteFrameImpl::close()

{

+ if (m_frame)

+ m_frame->setHasBeenClosed();

deref();

}

@@ -835,4 +838,3 @@ WebRemoteFrameImpl* WebRemoteFrameImpl::fromFrame(RemoteFrame& frame)

}

} // namespace blink

« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »