Source/core/frame/LocalDOMWindow.cpp - Issue 538323003: Have window.closed return true when frame is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 538323003: Have window.closed return true when frame is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Un-inline and improve formatting of Frame::setHasBeenClosed() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/LocalDOMWindow.cpp

diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp

index d6604f3b4211042f4662bf3159ad5b11d304fa56..0f2bba8b0b9086c909006581b9d073c0c5b3acb4 100644

--- a/Source/core/frame/LocalDOMWindow.cpp

+++ b/Source/core/frame/LocalDOMWindow.cpp

@@ -1195,7 +1195,7 @@ int LocalDOMWindow::scrollY() const

bool LocalDOMWindow::closed() const

{

- return !m_frame;

+ return !m_frame || m_frame->hasBeenClosed();

}

unsigned LocalDOMWindow::length() const

« no previous file with comments | « Source/core/frame/Frame.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »