LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html - Issue 538323003: Have window.closed return true when frame is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html

Issue 538323003: Have window.closed return true when frame is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Un-inline and improve formatting of Frame::setHasBeenClosed() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html ('k') | LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html

diff --git a/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html b/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html

index ca82951736706a16a85f083f2ed2ce97d7d424b5..8e515d77a16751e6288dcbd80ecf62c5901e077e 100644

--- a/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html

+++ b/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html

@@ -24,7 +24,8 @@ function runTest()

description("Tests access of cached DOMWindow properties after the associated frame is no longer in a web page. Test should not crash and properties should be set to sane defaults.");

var frame = document.getElementById("frame");

childWindow = frame.contentWindow;

- collectProperties();

+ // Have expected results assume that the frame hasn't been closed (=> window.closed = false.)

+ collectProperties(false);

frame.parentNode.removeChild(frame);

for (var i = 0; i < propertiesToVerify.length; ++i)

shouldBe(propertiesToVerify[i].property, propertiesToVerify[i].expected);