Source/web/WebLocalFrameImpl.cpp - Issue 538323003: Have window.closed return true when frame is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 538323003: Have window.closed return true when frame is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update m_hasBeenClosed comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index a4ef3ca69934b7c524ef56777bdbae44b3460cab..9f62bd60aed6cdadb26008285af540d5e9a360a4 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -498,6 +498,9 @@ void WebLocalFrameImpl::close()

{

m_client = 0;

+ if (m_frame)

+ m_frame->setHasBeenClosed();

deref(); // Balances ref() acquired in WebFrame::create

}

« Source/core/frame/Frame.h ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »