Have window.closed return true when frame is closed.

Source/core/frame/Frame.h

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999-2001 Lars Knoll <knoll@kde.org>
  *                     1999-2001 Antti Koivisto <koivisto@kde.org>
  *                     2000-2001 Simon Hausmann <hausmann@kde.org>
  *                     2000-2001 Dirk Mueller <mueller@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
@@ skipping 80 matching lines @@
     blink::WebLayer* remotePlatformLayer() const { return m_remotePlatformLayer; }
 
     Settings* settings() const; // can be null
 
     // FIXME: This method identifies a LocalFrame that is acting as a RemoteFrame.
     // It is necessary only until we can instantiate a RemoteFrame, at which point
     // it can be removed and its callers can be converted to use the isRemoteFrame()
     // method.
     bool isRemoteFrameTemporary() const { return m_remotePlatformLayer; }
 
+    bool hasBeenClosed() const { return m_hasBeenClosed; }
+    void setHasBeenClosed() { ASSERT(!m_hasBeenClosed); m_hasBeenClosed = true; }
+
 protected:
     Frame(FrameClient*, FrameHost*, FrameOwner*);
 
     mutable FrameTree m_treeNode;
 
     FrameHost* m_host;
     FrameOwner* m_owner;
 
     RefPtrWillBePersistent<LocalDOMWindow> m_domWindow;
 
 private:
     FrameClient* m_client;
     blink::WebLayer* m_remotePlatformLayer;
+
+    // The closing of a frame by the embedder may not trigger the
+    // immediate release of this Frame object -- there might be
+    // other RefPtrs to the Frame, up the stack or elsewhere. For Oilpan,

[Mads Ager (chromium), 2014/09/17 07:47:39]

Remove the Oilpan reference in this patch since Frame is still not in the Oilpan
heap here?

[sof, 2014/09/17 08:08:28]

Thanks, that would premature to mention. Removed.

+    // any release will only happen at the next GC (at the earliest.)
+    //
+    // Hence, keep a separate flag that's set when the frame is
+    // closed. It is consulted by window.closed.
+    bool m_hasBeenClosed;
 };
 
 inline FrameClient* Frame::client() const
 {
     return m_client;
 }
 
 inline void Frame::clearClient()
 {
     m_client = 0;
@@ skipping 13 matching lines @@
 {
     return m_treeNode;
 }
 
 // Allow equality comparisons of Frames by reference or pointer, interchangeably.
 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED(Frame)
 
 } // namespace blink
 
 #endif // Frame_h