Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 538273002: Avoid memcmp on potentially unpacked structs in MailboxManager::TargetNameLess (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid memcmp on potentially unpacked structs in MailboxManager::TargetNameLess R=piman@chromium.org Committed: https://crrev.com/4f45409615609a5bf0084b9a7670b2fffda8a952 Cr-Commit-Position: refs/heads/master@{#293428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gpu/command_buffer/service/mailbox_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
MailboxManager::Target name is just struct { unsigned target; Mailbox mailbox; }; and Mailbox is likely ...
6 years, 3 months ago (2014-09-04 23:23:30 UTC) #1
piman
lgtm
6 years, 3 months ago (2014-09-04 23:38:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/538273002/1
6 years, 3 months ago (2014-09-04 23:43:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as a796e41bbf7d85b47b934638ec2cefdc836fa16f
6 years, 3 months ago (2014-09-05 03:56:26 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f45409615609a5bf0084b9a7670b2fffda8a952
Cr-Commit-Position: refs/heads/master@{#293428}

Powered by Google App Engine
This is Rietveld 408576698