Issue 538263003: NaCl: add missing GYP dependancies on pthread_lib.

Issue 538263003: NaCl: add missing GYP dependancies on pthread_lib. (Closed)

Created:
6 years, 3 months ago by Nick Bray (chromium)

Modified:
6 years, 3 months ago

Reviewers:
bbudge, bradnelson, bradn

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

NaCl: add missing GYP dependancies on pthread_lib. BUG=none Committed: https://crrev.com/731b3521c0fda48786861e9c95795f3d2218a27b Cr-Commit-Position: refs/heads/master@{#293467}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	ppapi/ppapi_nacl.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ppapi/ppapi_nacl_test_common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 9 (3 generated)

Nick Bray (chromium)

bradnelson: GYP evil. Does injecting a dependency into a target actually work? bbudge: OWNER.

6 years, 3 months ago (2014-09-04 23:37:55 UTC) #2

bradn

Note this adds an order dependency, it does not force a link. lgtm

6 years, 3 months ago (2014-09-04 23:42:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/538263003/1

6 years, 3 months ago (2014-09-05 01:04:12 UTC) #7

commit-bot: I haz the power

Committed patchset #1 (id:1) as db88a9e5f7a27f79f89a878715b3909163dfdb2c

6 years, 3 months ago (2014-09-05 08:10:39 UTC) #8

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:37:43 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/731b3521c0fda48786861e9c95795f3d2218a27b
Cr-Commit-Position: refs/heads/master@{#293467}