proposed interface change at //net for webrtc

net/base/net_util.h

Index: net/base/net_util.h
diff --git a/net/base/net_util.h b/net/base/net_util.h
index c74dfd2ea48486b08e16be9fdb700b9d99f06bd0..5f537159c815cbd98c743e09040d74f38ac5595b 100644
--- a/net/base/net_util.h
+++ b/net/base/net_util.h
@@ -438,16 +438,41 @@ NET_EXPORT_PRIVATE int GetPortFromSockaddr(const struct sockaddr* address,
 // machine.
 NET_EXPORT_PRIVATE bool IsLocalhost(const std::string& host);
 
+// A subset of IP address attributes which is actionable to

[pauljensen, 2014/09/18 14:29:54]

is->are
to->by the?
Also add "Currently unimplemented for all hosts; IP_ADDRESS_ATTRIBUTE_NONE is
always returned." and update as you add implementations.

+// application layer.
+enum IPAddressAttributes {
+  IP_ADDRESS_ATTRIBUTE_NONE = 0,
+
+  // Temporary address is dynamic by nature and will not carry MAC
+  // address.
+  IP_ADDRESS_ATTRIBUTE_TEMPORARY = 1 << 0,
+
+  // Temporary address could become deprecated once the preferred
+  // lifetime is reached. It is still valid but shouldn't be used to
+  // create new connection.
+  IP_ADDRESS_ATTRIBUTE_DEPRECATED = 1 << 1,
+};
+
 // struct that is used by GetNetworkList() to represent a network
 // interface.
 struct NET_EXPORT NetworkInterface {
   NetworkInterface();
+
   NetworkInterface(const std::string& name,

[pauljensen, 2014/09/18 14:29:54]

Dead?

                    const std::string& friendly_name,
                    uint32 interface_index,
                    NetworkChangeNotifier::ConnectionType type,
                    const IPAddressNumber& address,
                    size_t network_prefix);
+
+  NetworkInterface(const std::string& name,
+                   const std::string& friendly_name,
+                   uint32 interface_index,
+                   NetworkChangeNotifier::ConnectionType type,
+                   const IPAddressNumber& address,
+                   size_t network_prefix,
+                   int ip_address_attributes);
+
   ~NetworkInterface();
 
   std::string name;
@@ -456,6 +481,7 @@ struct NET_EXPORT NetworkInterface {
   NetworkChangeNotifier::ConnectionType type;
   IPAddressNumber address;
   size_t network_prefix;
+  int ip_address_attributes;  // Combination of |IPAddressAttributes|.
 };
 
 typedef std::vector<NetworkInterface> NetworkInterfaceList;