proposed interface change at //net for webrtc

net/base/net_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NET_UTIL_H_
 #define NET_BASE_NET_UTIL_H_
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
@@ skipping 420 matching lines @@
                                            socklen_t address_len);
 
 // Returns true if |host| is one of the names (e.g. "localhost") or IP
 // addresses (IPv4 127.0.0.0/8 or IPv6 ::1) that indicate a loopback.
 //
 // Note that this function does not check for IP addresses other than
 // the above, although other IP addresses may point to the local
 // machine.
 NET_EXPORT_PRIVATE bool IsLocalhost(const std::string& host);
 
+// Only expose a subset of IPv6 address flags which is actionable to

[pauljensen, 2014/09/10 17:55:18]

Remove "Only expose".
I'm not sure "IPv6 address flags" is a known term/quantity.  Is this something
from an RFC?  Maybe use the term "IPv6 address attributes".

[lorenzo, 2014/09/11 06:06:10]

I don't think "address flags" is a standard term. "attributes" is fine.

[guoweis_webrtc, 2014/09/12 23:55:21]

Done. Changed the name to IPAddressAttributes.

[guoweis_webrtc, 2014/09/12 23:55:21]

Changed the name to IPAddressAttributes.

+// application layer. Addresses with flags which are not combination

[pauljensen, 2014/09/10 17:55:18]

Insert "a" in between "not combination"

[guoweis_webrtc, 2014/09/12 23:55:21]

Done.

+// of listed below will be filtered out from GetNetworkList.

[lorenzo, 2014/09/11 06:06:10]

I think this comment should just describe the flags, not talk about what
GetNetworkList will or will not filter out. That information should be in the
comments for GetNetworkList.

[guoweis_webrtc, 2014/09/12 23:55:21]

Done.

+enum IPv6AddressFlag {

[lorenzo, 2014/09/11 06:06:10]

Is there a reason for this enum to be IPv6-specific? I would imagine that there
are other flags you might want to associate with IP addresses.

[guoweis_webrtc, 2014/09/12 23:55:21]

Changed the enum name to IPAddressAttributes

+  IPV6_ADDRESS_FLAG_NONE =           0,
+
+  // Temporary address is dynamic by nature and will not carry MAC
+  // address.
+  IPV6_ADDRESS_FLAG_TEMPORARY =      1 << 0,
+
+  // Temporary address could become deprecated once the preferred
+  // lifetime is reached. It is still valid but shouldn't be used to
+  // create new connection.
+  IPV6_ADDRESS_FLAG_DEPRECATED =     1 << 1,
+};
+
 // struct that is used by GetNetworkList() to represent a network
 // interface.
 struct NET_EXPORT NetworkInterface {
   NetworkInterface();
   NetworkInterface(const std::string& name,
                    const std::string& friendly_name,
                    uint32 interface_index,
                    NetworkChangeNotifier::ConnectionType type,
                    const IPAddressNumber& address,
-                   size_t network_prefix);
+                   size_t network_prefix,
+                   int ipv6_flags);
   ~NetworkInterface();
 
   std::string name;
   std::string friendly_name;  // Same as |name| on non-Windows.
   uint32 interface_index;  // Always 0 on Android.
   NetworkChangeNotifier::ConnectionType type;
   IPAddressNumber address;
   size_t network_prefix;
+  int ipv6_flags; // Combination of |IPv6AddressFlag|.
 };
 
 typedef std::vector<NetworkInterface> NetworkInterfaceList;
 
 // Policy settings to include/exclude network interfaces.
 enum HostAddressSelectionPolicy {
   INCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES           = 0x0,
   EXCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES           = 0x1,
   // Include temp address only when interface has both permanent and
   // temp addresses.
@@ skipping 62 matching lines @@
   DSCP_CS5  = 40,  // Video
   DSCP_EF   = 46,  // Voice
   DSCP_CS6  = 48,  // Voice
   DSCP_CS7  = 56,  // Control messages
   DSCP_LAST = DSCP_CS7
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NET_UTIL_H_