proposed interface change at //net for webrtc

net/base/net_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NET_UTIL_H_
 #define NET_BASE_NET_UTIL_H_
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
@@ skipping 420 matching lines @@
                                            socklen_t address_len);
 
 // Returns true if |host| is one of the names (e.g. "localhost") or IP
 // addresses (IPv4 127.0.0.0/8 or IPv6 ::1) that indicate a loopback.
 //
 // Note that this function does not check for IP addresses other than
 // the above, although other IP addresses may point to the local
 // machine.
 NET_EXPORT_PRIVATE bool IsLocalhost(const std::string& host);
 
+// Only expose a subset of actionable IPv6 address flags to
+// application layer. Addresses with flags which are not combination
+// of listed below will be filtered out from GetNetworkList.
+enum IPv6AddressFlag {
+  IPV6_ADDRESS_FLAG_NONE           = 0x00,
+  // This enum follows the IFA definition in if_addr.h

[Ryan Sleevi, 2014/09/08 18:15:44]

This doesn't really add value for non-Linux Users.

You need to be explicit about what is documented.

[guoweis_webrtc, 2014/09/12 23:55:21]

Removed that line. 

+  IPV6_ADDRESS_FLAG_TEMPORARY      = 0x01,
+  IPV6_ADDRESS_FLAG_DEPRECATED     = 0x20,
+  IPV6_ADDRESS_FLAG_PERMANENT      = 0x80,

[Ryan Sleevi, 2014/09/08 18:15:44]

Why did you skip a bunch of flag values? Are you trying to be constant with some
other definition? Why?

From a mask perspective, does it make sense to be more readable of
1 << 1
1 << 2
1 << 3

etc

[guoweis_webrtc, 2014/09/12 23:55:21]

Done.

+};
+
 // struct that is used by GetNetworkList() to represent a network
 // interface.
 struct NET_EXPORT NetworkInterface {
   NetworkInterface();
   NetworkInterface(const std::string& name,
                    const std::string& friendly_name,
                    uint32 interface_index,
                    NetworkChangeNotifier::ConnectionType type,
                    const IPAddressNumber& address,
                    size_t network_prefix);
   ~NetworkInterface();
 
   std::string name;
   std::string friendly_name;  // Same as |name| on non-Windows.
   uint32 interface_index;  // Always 0 on Android.
   NetworkChangeNotifier::ConnectionType type;
   IPAddressNumber address;
   size_t network_prefix;
+  int ipv6_flags;

[Ryan Sleevi, 2014/09/08 18:15:44]

Document

[guoweis_webrtc, 2014/09/12 23:55:21]

I put a comment after the variable 
// Combination of |IPv6AddressFlag|.

Please let me know if this doesn't serve the purpose. 

 };
 
 typedef std::vector<NetworkInterface> NetworkInterfaceList;
 
 // Policy settings to include/exclude network interfaces.
 enum HostAddressSelectionPolicy {
   INCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES           = 0x0,
   EXCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES           = 0x1,
-  // Include temp address only when interface has both permanent and
-  // temp addresses.
-  INCLUDE_ONLY_TEMP_IPV6_ADDRESS_IF_POSSIBLE      = 0x2,
 };
 
 // Returns list of network interfaces except loopback interface. If an
 // interface has more than one address, a separate entry is added to
 // the list for each address.
 // Can be called only on a thread that allows IO.
 NET_EXPORT bool GetNetworkList(NetworkInterfaceList* networks,
                                int policy);
 
 // General category of the IEEE 802.11 (wifi) physical layer operating mode.
@@ skipping 51 matching lines @@
   DSCP_CS5  = 40,  // Video
   DSCP_EF   = 46,  // Voice
   DSCP_CS6  = 48,  // Voice
   DSCP_CS7  = 56,  // Control messages
   DSCP_LAST = DSCP_CS7
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NET_UTIL_H_