Issue 538233002: Fix problems discovered with gcc 4.9.1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 538233002: Fix problems discovered with gcc 4.9.1 (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -5 lines)			Patch
M	util/mac/process_reader_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	util/misc/initialization_state.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	util/misc/initialization_state_dcheck.h	View		1 chunk	+17 lines, -3 lines	0 comments	Download
M	util/test/posix/close_multiple.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

Yeah, that’s right, I fed everything to gcc instead of clang for code-hygiene purposes. (Well, ...

6 years, 3 months ago (2014-09-04 23:15:14 UTC) #2

Mark Mentovai

6 years, 3 months ago (2014-09-05 16:39:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 35865a0 (presubmit successful).