Cleanup RenderInline style propagation to continuations

Cleanup RenderInline style propagation to continuations

- Remove unnecessary RenderInline::setContinuation(). Push outline style
  in RenderInline::addChildIgnoringContinuation() along with original
  style propagation for 'position'.
- In updateStyleOfAnonymousBlockContinuations() create newBlockStyle
  only once. Fixed original issue when pushing 'position' by replacing
  createAnonymousStyleWithDisplay() with RenderStyle::clone().
  The issue caused just-set outline style to be lost because
  createAnonymousStyleWithDisplay() doesn't copy non-inherited styles.

BUG=405222
TEST=refactory only, no functional change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181566

[Xianzhu, 2014-09-04 22:46:25]

wangxianzhu@chromium.org changed reviewers:
+ dsinclair@chromium.org, jchaffraix@chromium.org, leviw@chromium.org

[dsinclair, 2014-09-05 13:45:34]

lgtm

[Julien - ping for review, 2014-09-05 19:57:35]

lgtm

https://codereview.chromium.org/538213002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderInline.cpp (right):

https://codereview.chromium.org/538213002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderInline.cpp:342: if
(!newStyle->isOutlineEquivalent(style()))
I would put a comment here to explain why this is needed.

[Xianzhu, 2014-09-05 21:23:44]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-09-05 21:24:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/538213002/20001

[Xianzhu, 2014-09-05 22:04:16]

https://codereview.chromium.org/538213002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderInline.cpp (right):

https://codereview.chromium.org/538213002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderInline.cpp:342: if
(!newStyle->isOutlineEquivalent(style()))
On 2014/09/05 19:57:35, Julien Chaffraix - PST wrote:
> I would put a comment here to explain why this is needed.

Done.

[commit-bot: I haz the power, 2014-09-06 03:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 03:25:27]

Exceeded time limit waiting for builds to trigger.

[Xianzhu, 2014-09-08 16:03:27]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-09-08 16:04:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/538213002/20001

[commit-bot: I haz the power, 2014-09-08 16:04:56]

Committed patchset #2 (id:20001) as 181566