Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 538183002: Add pop_back() to GrAllocator and add unit test. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add pop_back() to GrAllocator and add unit test. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/a1ae66d252edf6da932caed1fe43d11216e56c0e

Patch Set 1 #

Patch Set 2 : line wraps #

Patch Set 3 : Add comments #

Total comments: 7

Patch Set 4 : Address comments and put local struct type in anonymous namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1 line) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAllocator.h View 3 chunks +26 lines, -1 line 0 comments Download
A tests/GrAllocatorTest.cpp View 1 2 3 1 chunk +103 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
Split out from larger CL.
6 years, 3 months ago (2014-09-04 22:12:11 UTC) #2
robertphillips
lgtm + a suggestion, typo & question. https://codereview.chromium.org/538183002/diff/40001/tests/GrAllocatorTest.cpp File tests/GrAllocatorTest.cpp (right): https://codereview.chromium.org/538183002/diff/40001/tests/GrAllocatorTest.cpp#newcode21 tests/GrAllocatorTest.cpp:21: gCount -> ...
6 years, 3 months ago (2014-09-05 12:31:22 UTC) #3
bsalomon
https://codereview.chromium.org/538183002/diff/40001/tests/GrAllocatorTest.cpp File tests/GrAllocatorTest.cpp (right): https://codereview.chromium.org/538183002/diff/40001/tests/GrAllocatorTest.cpp#newcode21 tests/GrAllocatorTest.cpp:21: On 2014/09/05 12:31:22, robertphillips wrote: > gCount -> gNumInstances, ...
6 years, 3 months ago (2014-09-05 13:04:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/538183002/60001
6 years, 3 months ago (2014-09-05 13:06:39 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 13:13:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as a1ae66d252edf6da932caed1fe43d11216e56c0e

Powered by Google App Engine
This is Rietveld 408576698