Chromium Code Reviews

Issue 538143002: Fix test for master device. (Closed)

Created:
6 years, 3 months ago by kpschoedel
Modified:
6 years, 3 months ago
Reviewers:
sadrul, Daniel Erat
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix test for master device. BUG=406014 R=sadrul@chromium.org Committed: https://crrev.com/817ca9b5c2145d843f6ff154926db79535974778 Cr-Commit-Position: refs/heads/master@{#293781} Committed: https://crrev.com/6f5325380cb6459737193a6c929e2d817395d560 Cr-Commit-Position: refs/heads/master@{#294385}

Patch Set 1 #

Patch Set 2 : Augment InitGenericKeyEvent to fix tests. #

Patch Set 3 : rebase #

Patch Set 4 : sourceid vs deviceid #

Patch Set 5 : Identify virtual core keyboard. #

Unified diffs Side-by-side diffs Stats (+49 lines, -11 lines)
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments
M ui/events/event.cc View 1 chunk +1 line, -1 line 0 comments
M ui/events/test/events_test_utils_x11.h View 1 chunk +3 lines, -0 lines 0 comments
M ui/events/test/events_test_utils_x11.cc View 2 chunks +2 lines, -0 lines 0 comments
M ui/events/x/events_x_unittest.cc View 3 chunks +26 lines, -5 lines 0 comments
M ui/events/x/touch_factory_x11.h View 1 chunk +3 lines, -0 lines 0 comments
M ui/events/x/touch_factory_x11.cc View 3 chunks +8 lines, -3 lines 0 comments

Messages

Total messages: 20 (6 generated)
kpschoedel
6 years, 3 months ago (2014-09-04 21:34:32 UTC) #1
sadrul
lgtm
6 years, 3 months ago (2014-09-04 21:37:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/538143002/1
6 years, 3 months ago (2014-09-04 21:41:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11123) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/13192)
6 years, 3 months ago (2014-09-05 01:27:47 UTC) #6
kpschoedel
+ sadrul@ for ui/events/* + derat@ for chrome/browser/chromeos/events/event_rewriter_unittest.cc
6 years, 3 months ago (2014-09-05 21:08:16 UTC) #9
Daniel Erat
rubberstamp lgtm for c/b/chromeos
6 years, 3 months ago (2014-09-05 21:09:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/538143002/80001
6 years, 3 months ago (2014-09-08 19:23:45 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:80001) as 3bb6d05dcbaf53d2cc5e3143bc99ac7193e2c1eb
6 years, 3 months ago (2014-09-08 20:40:41 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/817ca9b5c2145d843f6ff154926db79535974778 Cr-Commit-Position: refs/heads/master@{#293781}
6 years, 3 months ago (2014-09-10 03:48:02 UTC) #14
kpschoedel
A revert of this CL (patchset #4 id:80001) has been created in https://codereview.chromium.org/560853003/ by kpschoedel@chromium.org. ...
6 years, 3 months ago (2014-09-10 15:15:38 UTC) #15
kpschoedel
Sadrul, could you take another look at the latest patch set (ui/events/x/touch_factory_x11.*)? The previous version ...
6 years, 3 months ago (2014-09-10 18:05:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/538143002/100001
6 years, 3 months ago (2014-09-11 13:22:35 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:100001) as 70873fa0ab76a1aba9e5bb9ced6a5e75a729d453
6 years, 3 months ago (2014-09-11 14:28:41 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 14:32:03 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6f5325380cb6459737193a6c929e2d817395d560
Cr-Commit-Position: refs/heads/master@{#294385}

Powered by Google App Engine