Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 538103003: Adding Text Selection Action Bar Menu Unit Test cases. (Closed)

Created:
6 years, 3 months ago by AKVT
Modified:
6 years, 1 month ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add text selection ActionBar tests Currently there is insufficient coverage for text selection ActionBar menu interaction. Add several basic tests covering such functionality. Committed: https://crrev.com/0491238962fd5f21446be0383ac4748a8e7f600d Cr-Commit-Position: refs/heads/master@{#301408}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changed the code based on review comments. #

Patch Set 3 : Fixed the review comments. #

Total comments: 2

Patch Set 4 : Fixed the review comments. #

Total comments: 1

Patch Set 5 : Added assert check before accessing ActionHandler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -115 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 7 chunks +108 lines, -102 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 1 2 3 4 2 chunks +36 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (4 generated)
AKVT
@jdduke & aurimas PTAL Please suggest if we can add some wrapper call in SelectActionModeCallback ...
6 years, 3 months ago (2014-09-04 19:12:48 UTC) #2
jdduke (slow)
not lgtm. I'd prefer we either figure out another way of testing this behavior that ...
6 years, 3 months ago (2014-09-04 19:31:00 UTC) #3
AKVT
@jdduke Thanks for the comments. Other than this, I am not finding easy way of ...
6 years, 3 months ago (2014-09-05 10:09:15 UTC) #4
jdduke (slow)
So, the problem is that this taste conflates several different concerns, which are: 1) Does ...
6 years, 3 months ago (2014-09-05 15:14:24 UTC) #5
AKVT
@jdduke PTAL. I have created a basic version. I would like to ask whether I ...
6 years, 1 month ago (2014-10-27 16:16:02 UTC) #8
jdduke (slow)
https://codereview.chromium.org/538103003/diff/60001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/538103003/diff/60001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1747 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1747: mActionHandler = new SelectActionModeCallback.ActionHandler() { Do we need to ...
6 years, 1 month ago (2014-10-27 16:31:25 UTC) #9
AKVT
On 2014/10/27 16:31:25, jdduke wrote: > https://codereview.chromium.org/538103003/diff/60001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java > File > content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java > (right): > > ...
6 years, 1 month ago (2014-10-27 16:37:12 UTC) #10
jdduke (slow)
On 2014/10/27 16:37:12, AKV wrote: > You mean while hiding the Select Action Bar, we ...
6 years, 1 month ago (2014-10-27 16:40:25 UTC) #11
AKVT
@jdduke PTAL. I kept one time object creation for ActionHandler https://codereview.chromium.org/538103003/diff/60001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/538103003/diff/60001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1747 ...
6 years, 1 month ago (2014-10-27 17:23:05 UTC) #12
jdduke (slow)
lgtm with one suggestion. https://codereview.chromium.org/538103003/diff/80001/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java File content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java (right): https://codereview.chromium.org/538103003/diff/80001/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java#newcode209 content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java:209: assertTrue(mContentViewCore.getSelectActionHandler().isSelectionEditable()); I'd add a |assertNotNull(mContentViewCore.getSelectActionHandler()| ...
6 years, 1 month ago (2014-10-27 18:18:54 UTC) #13
AKVT
On 2014/10/27 18:18:54, jdduke wrote: > lgtm with one suggestion. > > https://codereview.chromium.org/538103003/diff/80001/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java > File ...
6 years, 1 month ago (2014-10-27 18:28:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/538103003/100001
6 years, 1 month ago (2014-10-27 18:42:57 UTC) #16
jdduke (slow)
On 2014/10/27 18:28:52, AKV wrote: > On 2014/10/27 18:18:54, jdduke wrote: > > lgtm with ...
6 years, 1 month ago (2014-10-27 18:45:00 UTC) #17
AKVT
On 2014/10/27 18:45:00, jdduke wrote: > On 2014/10/27 18:28:52, AKV wrote: > > On 2014/10/27 ...
6 years, 1 month ago (2014-10-27 18:53:36 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:100001)
6 years, 1 month ago (2014-10-27 19:31:38 UTC) #19
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:32:27 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0491238962fd5f21446be0383ac4748a8e7f600d
Cr-Commit-Position: refs/heads/master@{#301408}

Powered by Google App Engine
This is Rietveld 408576698