Move execute_code_function to extensions.

extensions/common/constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/constants.h"
 
 namespace extensions {
 
 const char kExtensionScheme[] = "chrome-extension";
 const char kExtensionResourceScheme[] = "chrome-extension-resource";
@@ skipping 39 matching lines @@
 const char kSyncAppSettingsDirectoryName[] = "Sync App Settings";
 const char kSyncExtensionSettingsDirectoryName[] = "Sync Extension Settings";
 const char kManagedSettingsDirectoryName[] = "Managed Extension Settings";
 const char kStateStoreName[] = "Extension State";
 const char kRulesStoreName[] = "Extension Rules";
 const char kWebStoreAppId[] = "ahfgeienlihckogmohjhadlkjgocpleb";
 
 const char kMimeTypeJpeg[] = "image/jpeg";
 const char kMimeTypePng[] = "image/png";
 
+const char kNoCodeOrFileToExecuteError[] = "No source code or file specified.";
+const char kMoreThanOneValuesError[] = "Code and file should not be specified "

[Ken Rockot(use gerrit already), 2014/09/04 22:54:47]

Could you fix this constant name now that it's moving to general extensions
constants? How about kCodeAndFileNotAllowedError or something. And maybe the
text could be clarified "... should not both be specified."


Actually, on second look, are any of these constants referenced outside of
execute_code_function.cc? If not, please just move them into that file in an
anonymous namespace.

[Fady Samuel, 2014/09/04 22:59:59]

I don't want to block this CL but should these strings be internationalized?

+    "at the same time in the second argument.";
+const char kLoadFileError[] = "Failed to load file: \"*\". ";
+
 }  // namespace extensions
 
 namespace extension_misc {
 
 const int kExtensionIconSizes[] = {EXTENSION_ICON_GIGANTOR,     // 512
                                    EXTENSION_ICON_EXTRA_LARGE,  // 256
                                    EXTENSION_ICON_LARGE,        // 128
                                    EXTENSION_ICON_MEDIUM,       // 48
                                    EXTENSION_ICON_SMALL,        // 32
                                    EXTENSION_ICON_SMALLISH,     // 24
                                    EXTENSION_ICON_BITTY,        // 16
                                    // Additional 2x resources to load.
                                    2 * EXTENSION_ICON_MEDIUM,  // 96
                                    2 * EXTENSION_ICON_SMALL    // 64
 };
 
 const size_t kNumExtensionIconSizes = arraysize(kExtensionIconSizes);
 
 const IconRepresentationInfo kExtensionActionIconSizes[] = {
   { EXTENSION_ICON_ACTION, "19", ui::SCALE_FACTOR_100P },
   { 2 * EXTENSION_ICON_ACTION, "38", ui::SCALE_FACTOR_200P }
 };
 
 COMPILE_ASSERT(kNumExtensionActionIconSizes ==
                arraysize(kExtensionActionIconSizes),
                num_action_icon_sizes_must_be_in_sync_with_action_icon_sizes);
 
 }  // namespace extension_misc