Issue 538009: Fix case sensitivity issues and svn move patches for --sub_rep on Windows....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 538009: Fix case sensitivity issues and svn move patches for --sub_rep on Windows.... (Closed)

Created:
10 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fix case sensitivity issues and svn move patches for --sub_rep on Windows. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35839

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 3

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -8 lines)			Patch
M	scm.py	View	1	5 chunks	+25 lines, -4 lines	3 comments	Download
M	tests/scm_unittest.py	View	2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	trychange.py	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

10 years, 11 months ago (2010-01-08 23:09:23 UTC) #4

http://codereview.chromium.org/538009/diff/5001/7
File scm.py (right):

http://codereview.chromium.org/538009/diff/5001/7#newcode28
scm.py:28: paths = path.split('\\')
\\ -> os.pathsep
eh, whatever

http://codereview.chromium.org/538009/diff/5001/7#newcode38
scm.py:38: paths[i] = glob.glob(subpath + '*')[0][prev+1:len(subpath)]
Can you drop the '*' come to think of it, glob should still find it? Or does it
then not recase it?
I guess its ok since if anything else matches, it comes latest in sort order.

http://codereview.chromium.org/538009/diff/5001/7#newcode38
scm.py:38: paths[i] = glob.glob(subpath + '*')[0][prev+1:len(subpath)]
actually what happens if its the shortname? oh yuck sigh...
actually how about this:
paths[i] = glob.glob(subpath +'*')[0].split('\\')[-1]

Expand Messages | Collapse Messages