Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 538005: linux: grab device name before closing it (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Evan Martin
Modified:
3 years, 9 months ago
Reviewers:
awong (On leave)
CC:
chromium-reviews_googlegroups.com, scherkus, fbarchard, awong (On leave), Alpha
Visibility:
Public.

Description

linux: grab device name before closing it PcmClose frees the handle regardless of whether there's an error while shutting down, so grab the PcmName result first in case we want to use it in an error message. BUG=20006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35837

Patch Set 1 #

Patch Set 2 : better message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/audio/linux/alsa_output.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
Trybot results:
Commit:

Messages

Total messages: 2 (0 generated)
Evan Martin
(i confirmed this by checking the alsa source)
5 years, 1 month ago (2010-01-08 21:54:15 UTC) #1
awong (On leave)
5 years, 1 month ago (2010-01-08 21:58:41 UTC) #2
LGTM.

Good catch!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld dd99357-tainted