Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 537993002: Supervised users: Prototype of static client-side host blacklist. (Closed)

Created:
6 years, 3 months ago by Marc Treib
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Supervised users: Prototype of static client-side host blacklist. BUG=410824 Committed: https://crrev.com/4edbded7edb6d07dea0e5ccb339142ddb3ad121b Cr-Commit-Position: refs/heads/master@{#293483}

Patch Set 1 #

Patch Set 2 : is_sorted is Cpp11 (yay...) #

Total comments: 2

Patch Set 3 : experimental #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -3 lines) Patch
A chrome/browser/supervised_user/experimental/supervised_user_blacklist.h View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 1 2 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 3 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.h View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 1 2 4 chunks +11 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Marc Treib
PTAL!
6 years, 3 months ago (2014-09-04 13:55:51 UTC) #2
Bernhard Bauer
LGTM w/ a file naming nit: https://codereview.chromium.org/537993002/diff/20001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/537993002/diff/20001/chrome/chrome_browser.gypi#newcode2293 chrome/chrome_browser.gypi:2293: 'browser/supervised_user/prototype/supervised_user_blacklist.cc', Nit: I ...
6 years, 3 months ago (2014-09-04 15:12:15 UTC) #3
Marc Treib
https://codereview.chromium.org/537993002/diff/20001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/537993002/diff/20001/chrome/chrome_browser.gypi#newcode2293 chrome/chrome_browser.gypi:2293: 'browser/supervised_user/prototype/supervised_user_blacklist.cc', On 2014/09/04 15:12:15, Bernhard Bauer wrote: > Nit: ...
6 years, 3 months ago (2014-09-04 15:16:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/537993002/40001
6 years, 3 months ago (2014-09-04 15:19:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53519)
6 years, 3 months ago (2014-09-04 16:00:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/537993002/40001
6 years, 3 months ago (2014-09-05 07:17:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d2e70db4900cbdbb2d17eb6b32e6590b2555971f
6 years, 3 months ago (2014-09-05 08:44:47 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:14 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4edbded7edb6d07dea0e5ccb339142ddb3ad121b
Cr-Commit-Position: refs/heads/master@{#293483}

Powered by Google App Engine
This is Rietveld 408576698