Fix race condition in ExtensionApiTest.Messaging.

chrome/test/data/extensions/api_test/messaging/connect/test.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var listenOnce = chrome.test.listenOnce;
 var listenForever = chrome.test.listenForever;
 
 JSON.parse = function() {
   return "JSON.parse clobbered by extension.";
 };
@@ skipping 10 matching lines @@
   return "Object.prototype.toJSON clobbered by extension.";
 };
 
 // Keep track of the tab that we're running tests in, for simplicity.
 var testTab = null;
 
 chrome.test.getConfig(function(config) {
   chrome.test.runTests([
     function setupTestTab() {
       chrome.test.log("Creating tab...");
+      var newTab = null;
+      var doneListening = listenForever(chrome.tabs.onUpdated,
+        function(_, info, tab) {
+          if (newTab && tab.id == newTab.id && info.status == 'complete') {
+            chrome.test.log("Created tab: " + tab.url);
+            testTab = tab;
+            doneListening();
+          }
+        });
       chrome.tabs.create({
         url: "http://localhost:PORT/extensions/test_file.html"
                  .replace(/PORT/, config.testServer.port)
-      }, function(newTab) {
-        var doneListening = listenForever(chrome.tabs.onUpdated,
-          function(_, info, tab) {
-            if (tab.id == newTab.id && info.status == 'complete') {
-              chrome.test.log("Created tab: " + tab.url);
-              testTab = tab;
-              doneListening();
-            }
-          });
+      }, function(tab) {
+        newTab = tab;
       });
     },
 
     // Tests that postMessage to the tab and its response works.
     function postMessage() {
       var port = chrome.tabs.connect(testTab.id);
       port.postMessage({testPostMessage: true});
       listenOnce(port.onMessage, function(msg) {
         port.disconnect();
       });
@@ skipping 150 matching lines @@
       } catch(e) {
         error = e;
       }
       chrome.test.assertTrue(error != undefined);
 
       chrome.test.succeed();
     },
 
   ]);
 });