Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 537953002: Fix race condition in ExtensionApiTest.Messaging. (Closed)

Created:
6 years, 3 months ago by Alexander Semashko
Modified:
6 years, 3 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix race condition in ExtensionApiTest.Messaging. chrome.tabs.onUpdated may fire when the listener is not set up yet. BUG= Committed: https://crrev.com/0d9c77423b7733dfa7f3cf4545a2884a1379400b Cr-Commit-Position: refs/heads/master@{#293637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/test/data/extensions/api_test/messaging/connect/test.js View 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Alexander Semashko
6 years, 3 months ago (2014-09-04 15:14:21 UTC) #2
samuong
This looks reasonable to me but I'm probably not the best person to do the ...
6 years, 3 months ago (2014-09-05 17:12:53 UTC) #4
Matt Perry
lgtm
6 years, 3 months ago (2014-09-05 22:28:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahest@yandex-team.ru/537953002/1
6 years, 3 months ago (2014-09-06 08:23:46 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 13:42:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahest@yandex-team.ru/537953002/1
6 years, 3 months ago (2014-09-06 14:20:59 UTC) #11
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 16:21:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahest@yandex-team.ru/537953002/1
6 years, 3 months ago (2014-09-06 21:11:10 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as 05f9a7aee8065d9808389d7a4ea53cf9cce1cbff
6 years, 3 months ago (2014-09-06 21:17:12 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:25 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d9c77423b7733dfa7f3cf4545a2884a1379400b
Cr-Commit-Position: refs/heads/master@{#293637}

Powered by Google App Engine
This is Rietveld 408576698