chrome/tools/build/win/create_installer_archive.py - Issue 53793002: Initial implementation of Chrome Early Loading Framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/build/win/create_installer_archive.py

Issue 53793002: Initial implementation of Chrome Early Loading Framework (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: config fix Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/tools/build/win/create_installer_archive.py

diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py

index f5a99987adb5a204e19d12051e124a058845edf9..f16735b5c990deb4762fc572b04371b7c8774edb 100755

--- a/chrome/tools/build/win/create_installer_archive.py

+++ b/chrome/tools/build/win/create_installer_archive.py

@@ -180,6 +180,9 @@ def Readconfig(input_file, current_version):

current_version)

config = ConfigParser.SafeConfigParser(variables)

config.read(input_file)

+ # Add version assembly manifest to config here, since we cannot hardcode the

+ # file name in chrome.release.

+ config.set('GENERAL', '%s.manifest' % current_version, '%(VersionDir)s\\')

grt (UTC plus 2) 2013/11/07 03:04:23 this scares me since it involves magic. reading ch

return config

def RunSystemCommand(cmd, **kw):