chrome_elf/chrome_elf_main.cc - Issue 53793002: Initial implementation of Chrome Early Loading Framework

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_elf/chrome_elf_main.cc

Issue 53793002: Initial implementation of Chrome Early Loading Framework (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move InitChromeElf to after the fast notify Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/tools/flip_server/flip_test_utils.h"	5 #include <windows.h>

6	6

7 namespace net {	7 #include "chrome_elf/chrome_elf_main.h"

8	8

9 MockSMInterface::MockSMInterface() {	9 void InitChromeElf() {}
	gab 2013/11/11 20:11:38 Should this method be kept, I think we prefer no-o Should this method be kept, I think we prefer no-op methods to still have a comment in their implement as to why, i.e.: void InitChromeElf() { // No-op, used by dependents to force a load-time dependency on chrome_elf.dll. } Cait (Slow) 2013/11/12 16:33:54 Done. Show quoted text On 2013/11/11 20:11:38, gab wrote: > Should this method be kept, I think we prefer no-op methods to still have a > comment in their implement as to why, i.e.: > > void InitChromeElf() { > // No-op, used by dependents to force a load-time dependency on chrome_elf.dll. > } Done.
	10

	11 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {

	12 return TRUE;

10 }	13 }

11

12 MockSMInterface::~MockSMInterface() {

13 }

14

15 } // namespace net

OLD	NEW