chrome_elf/version_assembly_manifest.template - Issue 53793002: Initial implementation of Chrome Early Loading Framework

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_elf/version_assembly_manifest.template

Issue 53793002: Initial implementation of Chrome Early Loading Framework (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Generate manifest via gyp Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <assembly

	2 xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>

	3 <assemblyIdentity

	4 name='@MAJOR@.@MINOR@.@BUILD@.@PATCH@'

	5 version='@MAJOR@.@MINOR@.@BUILD@.@PATCH@'
	gab 2013/11/06 16:07:25 As discussed offline, we have no choice but to mak As discussed offline, we have no choice but to make the name the VERSION string for the version dir to be considered an assembly; this raises name conflicts concerns if an assembly uses the same name in the GAC (Global Assembly Cache) which has priority over private assemblies. We could mitigate this by making the "version" field here a random version string; different in every build (or perhaps even identical, but Chrome-unique; i.e., some kind of "key")!
	6 type='win32'/>

	7 <file name='chrome_elf.dll'/>

	8 </assembly>

OLD	NEW