chrome_elf/chrome_elf.gypi - Issue 53793002: Initial implementation of Chrome Early Loading Framework

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_elf/chrome_elf.gypi

Issue 53793002: Initial implementation of Chrome Early Loading Framework (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Clean up Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2

	3 'includes': [

	4 '../chrome/version.gypi',
	gab 2013/11/05 16:43:20 This version.gypi stuff is pretty cool :)! This version.gypi stuff is pretty cool :)!
	5 ],

	6 'targets': [

	7 {

	8 'target_name': 'chrome_elf',

	9 'type': 'shared_library',

	10 'include_dirs': [

	11 '..',
	gab 2013/11/05 16:43:20 nit: overly indented? nit: overly indented? Cait (Slow) 2013/11/06 00:30:15 Done. Show quoted text On 2013/11/05 16:43:20, gab wrote: > nit: overly indented? Done.
	12 ],

	13 'sources': [

	14 'chrome_elf.def',

	15 'chrome_elf_main.cc',

	16 'chrome_elf_main.h',

	17 ],

	18 'actions' : [

	19 {

	20 'action_name': 'chrome_exe_manifest',

	21 'variables': {

	22 'template_input_path':

	23 'chrome_exe_manifest.template',

	24 },

	25 'inputs': [

	26 '<(template_input_path)',

	27 '<(version_path)',

	28 ],

	29 'outputs': [

	30 '<(SHARED_INTERMEDIATE_DIR)/chrome_elf/version_assembly.manifest',

	31 ],

	32 'action': [

	33 'python', '<(version_py_path)',

	34 '-f', '<(version_path)',

	35 '<(template_input_path)',

	36 '<@(_outputs)',

	37 ],

	38 'message': 'Generating additional manifest files'
	gab 2013/11/05 16:43:20 Seems you could do something like 'Generating <@(_ Seems you could do something like 'Generating <@(_outputs)', e.g., https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome.gyp&...
	39 },

	40 ],

	41 },

	42 ],

	43 }

OLD	NEW