chrome/chrome_elf/chrome_elf_main.h - Issue 53793002: Initial implementation of Chrome Early Loading Framework

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/chrome_elf/chrome_elf_main.h

Issue 53793002: Initial implementation of Chrome Early Loading Framework (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Assemblies Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	grt (UTC plus 2) 2013/11/05 03:08:36 nit: there's no " (c)" in the most recent boilerpl nit: there's no " (c)" in the most recent boilerplate. remove it here and elsewhere. Cait (Slow) 2013/11/05 05:39:06 Done. Show quoted text On 2013/11/05 03:08:36, grt wrote: > nit: there's no " (c)" in the most recent boilerplate. remove it here and > elsewhere. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_CHROME_ELF_CHROME_ELF_MAIN_H_

	6 #define CHROME_CHROME_ELF_CHROME_ELF_MAIN_H_

	7

	8 extern "C" {
	grt (UTC plus 2) 2013/11/05 03:08:36 nit: extern "C" void InitHelper(); nit: extern "C" void InitHelper(); Cait (Slow) 2013/11/05 05:39:06 Done. Show quoted text On 2013/11/05 03:08:36, grt wrote: > nit: > extern "C" void InitHelper(); Done.
	9 void InitHelper();
	grt (UTC plus 2) 2013/11/05 03:08:36 is there a better name for this? maybe InitChromeE is there a better name for this? maybe InitChromeElf()? Cait (Slow) 2013/11/05 05:39:06 Done. Show quoted text On 2013/11/05 03:08:36, grt wrote: > is there a better name for this? maybe InitChromeElf()? Done.
	10 }

	11

	12 #endif // CHROME_CHROME_ELF_CHROME_ELF_MAIN_H_

OLD	NEW