chrome/chrome_elf.gypi - Issue 53793002: Initial implementation of Chrome Early Loading Framework

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/chrome_elf.gypi

Issue 53793002: Initial implementation of Chrome Early Loading Framework (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Assemblies Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 {

	2

	3 'includes': [

	4 'version.gypi',

	5 ],

	6 'targets': [

	7 {

	8 'target_name': 'chrome_elf',
	grt (UTC plus 2) 2013/11/05 03:08:36 does this target depend on anything in src/chrome? does this target depend on anything in src/chrome? i wonder if chrome_elf should be its own top-level entity (in src/) rather than in src/chrome. what else might be in here? Cait (Slow) 2013/11/05 05:39:06 I was wondering this too. I've moved it up a level Show quoted text On 2013/11/05 03:08:36, grt wrote: > does this target depend on anything in src/chrome? i wonder if chrome_elf should > be its own top-level entity (in src/) rather than in src/chrome. what else might > be in here? I was wondering this too. I've moved it up a level.
	9 'type': 'shared_library',

	10 'include_dirs': [

	11 '..',

	12 ],

	13 'sources': [

	14 'chrome_elf/chrome_elf.def',

	15 'chrome_elf/chrome_elf_main.cc',

	16 'chrome_elf/chrome_elf_main.h',

	17 ],

	18 'dependencies' : [

	19 'chrome_exe_manifest',

	20 ]

	21 },

	22 {

	23 'target_name': 'chrome_exe_manifest',

	24 'type': 'none',

	25 'sources': [

	26 'chrome_elf/chrome_exe_manifest.template',

	27 ],

	28 'rules': [
	robertshield 2013/11/05 02:23:55 Thinking about this a bit more, I believe there is Thinking about this a bit more, I believe there is some redundancy here. Instead of a 'rules' section, could this be accomplished by moving the 'action' up to an 'actions' section as with e.g. https://code.google.com/p/chromium/codesearch#chromium/src/ui/ozone/ozone.gyp... Cait (Slow) 2013/11/05 05:39:06 Done. Show quoted text On 2013/11/05 02:23:55, robertshield wrote: > Thinking about this a bit more, I believe there is some redundancy here. Instead > of a 'rules' section, could this be accomplished by moving the 'action' up to an > 'actions' section as with e.g. > https://code.google.com/p/chromium/codesearch#chromium/src/ui/ozone/ozone.gyp... Done.
	29 {

	30 'rule_name': 'chrome_exe_manifest',

	31 'extension': 'template',

	32 'variables': {

	33 'template_input_path':

	34 'chrome_elf/chrome_exe_manifest.template',

	35 },

	36 'inputs': [

	37 '<(template_input_path)',

	38 '<(version_path)',

	39 ],

	40 'outputs': [

	41 '<(SHARED_INTERMEDIATE_DIR)/chrome_elf/version_assembly.manifest',

	42 ],

	43 'action': [

	44 'python', '<(version_py_path)',

	45 '-f', '<(version_path)',

	46 '<(template_input_path)',

	47 '<@(_outputs)',

	48 ],

	49 'process_outputs_as_sources': 0,

	50 'message': 'Generating additional manifest files'

	51 },

	52 ],

	53 },

	54 ],

	55 }

OLD	NEW

« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_elf/chrome_elf.def » ('j') | chrome/chrome_elf/chrome_elf_main.h » ('J')