chrome/chrome_elf/chrome_elf.manifest - Issue 53793002: Initial implementation of Chrome Early Loading Framework

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/chrome_elf/chrome_elf.manifest

Issue 53793002: Initial implementation of Chrome Early Loading Framework (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <assembly

	2 xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>

	3 <assemblyIdentity name='chrome_elf' version='0.0.0.0'
	gab 2013/10/31 13:44:31 Before using version 0.0.0.0 we probably want to u Before using version 0.0.0.0 we probably want to understand what this field means exactly (I used 0.0.0.0 for the component build because "it works", but I have no idea whether it makes sense to ship this to a billion people ;)!)
	4 type='win32'/>
	gab 2013/10/31 13:44:31 This also needs investigation; win32 is probably w This also needs investigation; win32 is probably wrong for 64-bit builds.
	5 <file name='chrome_elf.dll'/>
	gab 2013/10/31 13:44:31 "file name" is probably not required if the manife "file name" is probably not required if the manifest is embedded.
	6 </assembly>

OLD	NEW