Regexp: Refactor ChoiceNode::Emit

Regexp: Refactor ChoiceNode::Emit

BUG=
R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23694

[Erik Corry, 2014-09-04 10:00:49]

erik.corry@gmail.com changed reviewers:
+ yangguo@chromium.org

[Erik Corry, 2014-09-04 10:02:38]

This is a pure refactoring change.  There are no changes to functionality, and I
have verified with a very large sample of regexps from the web that the
generated code is the same, right down to asking the regexp macro assembler to
create and bind the same labels that are unused.

[Yang, 2014-09-04 11:31:02]

On 2014/09/04 10:02:38, Erik Corry wrote:
> This is a pure refactoring change.  There are no changes to functionality, and
I
> have verified with a very large sample of regexps from the web that the
> generated code is the same, right down to asking the regexp macro assembler to
> create and bind the same labels that are unused.

LGTM with nit.

[Yang, 2014-09-04 11:31:12]

https://codereview.chromium.org/537913002/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://codereview.chromium.org/537913002/diff/1/src/jsregexp.cc#newcode4133
src/jsregexp.cc:4133: bool is_last = i != choice_count - 1;
Shouldn't this be is_not_last?

[Yang, 2014-09-04 11:31:13]

https://codereview.chromium.org/537913002/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://codereview.chromium.org/537913002/diff/1/src/jsregexp.cc#newcode4133
src/jsregexp.cc:4133: bool is_last = i != choice_count - 1;
Shouldn't this be is_not_last?

[Erik Corry, 2014-09-04 12:25:40]

https://codereview.chromium.org/537913002/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://codereview.chromium.org/537913002/diff/1/src/jsregexp.cc#newcode4133
src/jsregexp.cc:4133: bool is_last = i != choice_count - 1;
On 2014/09/04 11:31:13, Yang wrote:
> Shouldn't this be is_not_last?

Changed the sense instead of the name in order to avoid double negation.

[Erik Corry, 2014-09-04 12:27:58]

The CQ bit was checked by erik.corry@gmail.com

[commit-bot: I haz the power, 2014-09-04 12:28:21]

CQ is trying da patch. Follow status at
 https://v8-status.appspot.com/cq/erik.corry@gmail.com/537913002/20001

[commit-bot: I haz the power, 2014-09-04 12:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 12:28:23]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Erik Corry, 2014-09-04 12:47:28]

Committed patchset #2 (id:20001) manually as 23694 (presubmit successful).