Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 537893003: Move view logic from FocusRingLayer to FocusRingController. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@focus_ring_0_force_on
Project:
chromium
Visibility:
Public.

Description

Move view logic from FocusRingLayer to FocusRingController. BUG=314889 Committed: https://crrev.com/9e3a723c08cc363f7def9b4ec01a4eca8b7faba4 Cr-Commit-Position: refs/heads/master@{#294445}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -87 lines) Patch
M chrome/browser/chromeos/ui/focus_ring_controller.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_controller.cc View 1 2 chunks +48 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.h View 1 2 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.cc View 4 chunks +12 lines, -64 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dmazzoni
6 years, 3 months ago (2014-09-10 21:31:53 UTC) #2
xiyuan
LGTM with nits https://codereview.chromium.org/537893003/diff/1/chrome/browser/chromeos/ui/focus_ring_controller.cc File chrome/browser/chromeos/ui/focus_ring_controller.cc (right): https://codereview.chromium.org/537893003/diff/1/chrome/browser/chromeos/ui/focus_ring_controller.cc#newcode89 chrome/browser/chromeos/ui/focus_ring_controller.cc:89: gfx::Rect layer_bounds = view_bounds; |layer_bounds| seems ...
6 years, 3 months ago (2014-09-10 23:03:17 UTC) #3
dmazzoni
https://codereview.chromium.org/537893003/diff/1/chrome/browser/chromeos/ui/focus_ring_controller.cc File chrome/browser/chromeos/ui/focus_ring_controller.cc (right): https://codereview.chromium.org/537893003/diff/1/chrome/browser/chromeos/ui/focus_ring_controller.cc#newcode89 chrome/browser/chromeos/ui/focus_ring_controller.cc:89: gfx::Rect layer_bounds = view_bounds; On 2014/09/10 23:03:16, xiyuan wrote: ...
6 years, 3 months ago (2014-09-11 18:31:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/537893003/20001
6 years, 3 months ago (2014-09-11 18:33:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a575933c080619207aa2109c32be0755f1524c0c
6 years, 3 months ago (2014-09-11 19:46:37 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:02:36 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9e3a723c08cc363f7def9b4ec01a4eca8b7faba4
Cr-Commit-Position: refs/heads/master@{#294445}

Powered by Google App Engine
This is Rietveld 408576698