Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 537893002: Fix crash on chrome://sync-internals when sync is disabled. (Closed)

Created:
6 years, 3 months ago by Alexander Semashko
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash on chrome://sync-internals when sync is disabled. BUG= Committed: https://crrev.com/eaa12c7bbc8a2697d71676629b3f2bb06150741c Cr-Commit-Position: refs/heads/master@{#293330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/ui/webui/sync_internals_message_handler.cc View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Alexander Semashko
6 years, 3 months ago (2014-09-04 09:48:22 UTC) #2
Alexander Semashko
6 years, 3 months ago (2014-09-04 09:55:56 UTC) #5
Nikita (slow)
lgtm
6 years, 3 months ago (2014-09-04 12:00:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahest@yandex-team.ru/537893002/1
6 years, 3 months ago (2014-09-04 12:03:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9995)
6 years, 3 months ago (2014-09-04 13:20:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahest@yandex-team.ru/537893002/1
6 years, 3 months ago (2014-09-04 13:31:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10013)
6 years, 3 months ago (2014-09-04 14:44:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahest@yandex-team.ru/537893002/1
6 years, 3 months ago (2014-09-04 14:50:30 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10046)
6 years, 3 months ago (2014-09-04 16:22:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahest@yandex-team.ru/537893002/1
6 years, 3 months ago (2014-09-04 18:04:37 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5acc6cdedab10e35775fd862b84e7fde42898e83
6 years, 3 months ago (2014-09-04 20:46:10 UTC) #22
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:28 UTC) #23
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eaa12c7bbc8a2697d71676629b3f2bb06150741c
Cr-Commit-Position: refs/heads/master@{#293330}

Powered by Google App Engine
This is Rietveld 408576698