Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 537863002: Video Player: fix misc bugs (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: fix misc bugs - Add null-checks - Return an empty mime/thumbnailUrl instead of error if request is succeeded (media_manager.js) - Make savedVolume_ consistent (media_controls.js) BUG=none TEST=manual Committed: https://crrev.com/f1305fc02d43f2ad611257b7d787a66b29507deb Cr-Commit-Position: refs/heads/master@{#293328}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase & fix bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M ui/file_manager/video_player/js/cast/cast_video_element.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/video_player/js/cast/media_manager.js View 2 chunks +9 lines, -7 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 1 2 8 chunks +17 lines, -2 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 3 months ago (2014-09-04 08:10:06 UTC) #2
fukino
On 2014/09/04 08:10:06, yoshiki wrote: > @fukino-san, PTAL. Thanks. lgtm.
6 years, 3 months ago (2014-09-04 08:35:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/537863002/40001
6 years, 3 months ago (2014-09-04 11:21:54 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 235a50fdb2b79a6f6e0970a655f58430ee341dce
6 years, 3 months ago (2014-09-04 20:09:29 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:24 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1305fc02d43f2ad611257b7d787a66b29507deb
Cr-Commit-Position: refs/heads/master@{#293328}

Powered by Google App Engine
This is Rietveld 408576698