Issue 537823002: [EasyUnlock] Remove "All set!" notification strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 537823002: [EasyUnlock] Remove "All set!" notification strings. (Closed)

Created:
6 years, 3 months ago by Ilya Sherman

Modified:
6 years, 2 months ago

Reviewers:
Tim Song

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[EasyUnlock] Remove "All set!" notification strings. BUG=409443 TEST=Set up Easy Unlock. Once finished, there shouldn't be an "All set!" notification shown. R=tengs@chromium.org Committed: https://crrev.com/759c09147eb71adfae9d455bc40f5423a9927209 Cr-Commit-Position: refs/heads/master@{#297063}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -16 lines)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -7 lines	0 comments	Download
	M	chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/537823002/1

6 years, 2 months ago (2014-09-26 22:00:23 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as c2ff20b5a3437dfcf453f2288b0e8740243d0145

6 years, 2 months ago (2014-09-26 22:59:32 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 23:00:38 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/759c09147eb71adfae9d455bc40f5423a9927209
Cr-Commit-Position: refs/heads/master@{#297063}