Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 537813002: Revert of Add LocationBar PageAction tests (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
Finnur, Devlin, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add LocationBar PageAction tests (patchset #4 id:80001 of https://codereview.chromium.org/512693003/) Reason for revert: Flaky test see the following runs where the test fails even with 3 retries http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9713 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9656 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9574 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9511 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9405 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9367 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9252 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9253 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9223 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9213 Original issue's description: > Add LocationBar PageAction tests > > Page actions in the location bar have been somewhat loosely tested as a side- > effect of the page actions api testing, but (near as I can tell), we never > explicity test the ui for page actions. > > This is a problem because the extensions tests shouldn't care about the UI, and > soon won't, since where the page actions are in the UI may change (i.e., > location bar vs toolbar). > > Fix this by adding a few basic UI tests for page actions in the location bar. > > BUG=408261 > > Committed: https://chromium.googlesource.com/chromium/src/+/0abaca08e99fa6671758a96829b99aa941696e41 TBR=finnur@chromium.org,sky@chromium.org,rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true BUG=408261 Committed: https://crrev.com/6de6c6eaee01e8aa52e3e380fc2fcd1cc1ef2445 Cr-Commit-Position: refs/heads/master@{#293253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -160 lines) Patch
D chrome/browser/ui/location_bar/location_bar_browsertest.cc View 1 chunk +0 lines, -159 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Add LocationBar PageAction tests
6 years, 3 months ago (2014-09-04 03:25:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/537813002/1
6 years, 3 months ago (2014-09-04 03:26:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 854c5c5283ea112636689556a98fcd4155f1a81f
6 years, 3 months ago (2014-09-04 03:28:21 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6de6c6eaee01e8aa52e3e380fc2fcd1cc1ef2445
Cr-Commit-Position: refs/heads/master@{#293253}

Powered by Google App Engine
This is Rietveld 408576698